From: fungi@yuggoth.org
On 2025-08-15 18:53:38 -0700 (-0700), Russ Allbery wrote:
>Otto Kek€€l€€inen writes:
[...]
>> It is not expensive to do reviews.
[...]
>It is *sometimes* not expensive to do reviews. Sometimes it is quite
>expensive.
[...]
I just want to chime in and say that a significant portion of my
workday too is spent doing code review. I do find it relevant and
useful, however I expect if you asked my employer they would not
refer to my time as inexpensive... at least I certainly hope they
don't see me that way. Code review done right takes significant
time, and I'm not even sure I'm doing it entirely "right" in many
cases, but I also prefer not to see the effort I invest devalued as
"not expensive."
>a Gerrit instance that probably doesn't exist any more
[...]
If you're referring to gerrit.openafs.org, it's still up and
running. As an aside, I really wish the GitHub/GitLab generation
could experience and appreciate how superior of a code review
platform Gerrit really is (not as much the one for OpenAFS because
it's not been upgraded in close to a decade, but more generally).
Not going to turn this into a religious debate though...
--
Jeremy Stanley
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEl65Jb8At7J/DU7LnSPmWEUNJWCkFAmigxaJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk3
QUU0OTZGQzAyREVDOUZDMzUzQjJFNzQ4Rjk5NjExNDM0OTU4MjkACgkQSPmWEUNJ
WCmD2hAAhKiDDf19YvdtTiUF00m7qKtqinCLq4eAuIHTzwcDXl9ZruoRAeuYNEMS
jAvujqjxPEAMbRrg0QyjCbUbHoq21PePnoe9Ej45W2lLtb24FO4UmBAt+H5seWoI
eNH+w1nyp0IE8X9+iaIfLvvWMx8ByKeBD38RcJo2QHoeLQL6yNfN76uDjkBcNPW9
XyR3c/I22TQm4HqbYf1s4nWHCSE6F3qbUvt0zpnQTWjuKpVTubi2/2ea/1LFPvxS
YEXvBDu2CQbXCFV+S8bwJRbnvY3jDcEAqWmheG8/mIXfn89E2gzLz2OxO4D7Rhml
5+lL7Eh+fYvD7RTcY80wtTLRPOVVAqd1+YMWii2/V0iMrhPKrjlUX2dncfYSSDTw
mY3nZvk2OxW2vwVa1ch3bXfqRSkG9gX9ja1JbjgGbWLTmNagaPx49iiQHiXWW0Oc
tgpuYIc8AKVYSk5q4RF/2QO7YEhh7axi5eq4NgZ2C6ho1c/IS32VdPjdp/TZ7F6f
o2d4MGG5Jelyh3QBJ3iLI5TQNIJmKCLuBFkdZOT+Rup0DnPlqP4SwVnFRmQaxxnA
nBmJmX8/TCl57GpngqYVOtn4ejuigfNQ84mJVbMNIncJq02xMpBSXMDVrHYCAdOx
8Msp9MUMMh4k+MiHNQH8XrYNjCF8QtAkLoOR2dEcaWJN75jTsqw=
=Maj9
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)
|