home  bbs  files  messages ]

      ZZLI4422             linux.debian.devel             1179 messages      

[ previous | next | reply ]

[ list messages | list forums ]

  Msg # 1067 of 1179 on ZZLI4422, Sunday 8-16-25, 8:23  
  From: RUSS ALLBERY  
  To: NIELS THYKIER  
  Subj: Re: Gerrit and different merge UIs  
 From: rra@debian.org 
  
 Niels Thykier  writes: 
  
 > I think it has something like that since you can go to 
 > https://salsa.debian.org/debian/routine-update/-/merge_requests/17/commits 
 > and being able to click into each commit from there. From the MR, there is 
 > a "Commits (N)" tab if you don't like constructing URLs manually. 
  
 > Not sure if it is at the same level as GitHub commit-by-commit review 
 > feature, you can at least see each commit in the MR. 
  
 Great, thank you! Yeah, I think that's roughly equivalent. It has the 
 important parts for me, which are being able to leave line-by-line 
 comments in the per-commit view and easily navigate from commit to commit 
 in the MR. 
  
 I really like to have an MR incorporate all the changes needed for a 
 particular higher-level development goal, but with small individual 
 commits and individual review of the commits, for (I think) roughly the 
 same reason that projects like the Linux kernel use patch series. That 
 way, each commit can make one semantic change and therefore be easier to 
 review on its own, but the MR as a whole can implement an entire feature 
 or bug fix that conceptually makes sense as a unit. 
  
 The only thing that I think is still missing from that workflow is being 
 able to merge commits 1-3, 5, and 7, but leave the MR open while commits 4 
 and 6 are still being discussed. 
  
 -- 
 Russ Allbery (rra@debian.org)               
  
 --- SoupGate-Win32 v1.05 
  * Origin: you cannot sedate... all the things you hate (1:229/2) 

[ list messages | list forums | previous | next | reply ]

search for:

328,084 visits
(c) 1994,  bbs@darkrealms.ca