
| Msg # 1068 of 1179 on ZZLI4422, Sunday 8-16-25, 8:23 |
| From: JEREMY STANLEY |
| To: RUSS ALLBERY |
| Subj: Re: Gerrit and different merge UIs (was: |
From: fungi@yuggoth.org On 2025-08-16 12:42:53 -0700 (-0700), Russ Allbery wrote: [...] >That said, GitHub at least has gotten a lot better over the years. In >particular, they added incremental reviews (only showing you the bits that >have changed since your previous review), commit-by-commit review (or >maybe that's always been there and I just figured out how to find it), and >merge queues, which get pretty close to the UI experience that I liked >with Gerrit. [...] The more fundamental difference with Gerrit's approach, for me, is that you're proposing and revising a patch or series of patches and adjusting it until it appears the way you and reviewers want it to appear in the target branch's history. Gerrit supplies tooling necessary for comparing between arbitrary revisions of a patch, so there's no need to heap on fixes in subsequent commits, you just revise the commit (or series of related commits) repeatedly until it's in good enough shape to be merged. This is essentially the workflow used on LKML as well, but with a stateful service and Git interface rather than a mailing list full of threads with attachments. By comparison, I find the common GitHub and GitLab PR/MR workflows extremely frustrating in the way that they fail to preserve state or allow fluid reviewer discussion across revisions (at least GitHub has finally stopped vanishing all the comments when you rebase!), but I understand it's all a matter of personal preference and what sorts of workflows you get accustomed to. For me, doing code review long before GitHub existed, it has always seemed like a social media platform with code hosting bolted on, struggling to catch up with the features of review-oriented platforms. Sadly, GitLab copied much of GitHub's design mistakes for the sake of user familiarity/acquisition. -- Jeremy Stanley -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEl65Jb8At7J/DU7LnSPmWEUNJWCkFAmig+ClfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk3 QUU0OTZGQzAyREVDOUZDMzUzQjJFNzQ4Rjk5NjExNDM0OTU4MjkACgkQSPmWEUNJ WCnHDg/+MoMG3PtvQrEIpzuT1unYgE7hbxvGbEL2fUC7Gwc2wSjBVXbBQ7EQ32NM 1v2A+jxXLtMOqS+OR9UOSd1xotlXVDnMBJPRs2df4SHr04J8mljQkxRqiuvvN8B9 OwFERTjkmRNYgrztF5oBo9Qwf7xFfLvCHPq2JZJHMV9OcVUUSg4gREIfd277gLHT FIRSCThvzxrYsaDJz03mV36MtfQjoRfg/QqOfcRUPXHnl8DCDHRxPUQsZE0oXkVh lR881ZC9tRmwcRUYZQ5TafQn5x4lbf05ihqhPTFtqLZex1KFkV1ruSuXV/RSk1By cyp+vi+Hy9uzcAzJXYIzCTAYCsrPTV6fn/mY5v39vbHWjl46ApYqlukUk6Vh7xHZ 0hhGhPRuGOV2sYvb3lI1jFL8xEigY1Q7nnj9qIUFosx4Kcsdu7BgCSIO4peLqZm1 W+0T7AH37Pdu8nNns2cJJTEq0iysv0nCrbVuUa3CJCskzIPOkHrH5eeNyCAC9O4K X7QbcDIQd0d3S1GuMo3JIis5LbZ+hZjpXp9jpyRb8+FOXIeAl9CzkXNXTA/Ue4fQ paYKqqiC1ouFj69OGAqoE+/BgeB56m3wHXXyO7ZNVfTlaG6b6+GFUzyXW2DvjSZa dMbxKImTuchgr9flF08BvWjOnSLFspqeZr09olt3kQDO1GONP5s= =pKZ8 -----END PGP SIGNATURE----- --- SoupGate-Win32 v1.05 * Origin: you cannot sedate... all the things you hate (1:229/2) |
328,097 visits
(c) 1994, bbs@darkrealms.ca