From: roam@ringlet.net
On Sun, Aug 17, 2025 at 09:34:14PM +0100, Richard Lewis wrote:
> "Theodore Ts'o" writes:
>
> > In some cases, if it's a patch sent via e-mail, I'll just fix up the
> > patch and then let the contributor know that they failed to do error
> > checking, or their patch had a buffer overrun and result in a security
> > vulnerability etc. But with a merge request, all I can do is explain
> > what they did wrong, and ask them to resubmit the merge request.
>
> Not looking to argue the main point (90% of everything is crud, and i
> dont think anyone things every contribution must be accepted), but this
> statement confused me: the merge request is already in git, so i dont
> understand why people think it is harder to use than a patch attached to
> an email? you can check out a merge request and amend or cherry pick
> commits. you could even run git diff and pipe the result into a patch
> and use whatever existing workflow works for the bts?
...but how do you then tell the Git forge to use your changes when
you want to tell it to merge this merge request?
G'luck,
Peter
--
Peter Pentchev roam@ringlet.net roam@debian.org peter@morpheusly.com
PGP key: https://www.ringlet.net/roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEELuenpRf8EkzxFcNUZR7vsCUn3xMFAmiiP6AACgkQZR7vsCUn
3xM/HQ//fyAh3VDiG0uCMnfyxJzXjRPzkXiEDFzhzNuR4XE/3Lp5gy9yRhZ4EUhG
U754U/pwJERsWpmfEULk4rGUWVajknQSj0+lwxhzXvmuqQJ3PqrQBhGiopyew3HH
2FJUnsliaGHZFVjxOKFvYR1N4cJn2MkJWd0eUrEtUJ/3z34FSrIzo6XBxYN5ra80
Bsxp13OLC2sW7b6hmj7OcL8xPUu4nwr8BuJEFqAyHjztY4PH5qa0dpBO6f47LRlT
M5eNGrvmEiyZNeakVRtSPYuTmBsrzbJCOUlZJ+XO01Sf90NtPLnl6fQrs5/gWKBE
5b6vCN5f+nyc207otJBx0wit49XPtLCi4MaNJfAePJeKiTCuKnxdYhLi1SrmBwhQ
epsrMn0Lb7RnW8LxxejF5oN1NPL4Jw6p5POrfTJnUFOvIkFOrCLeBDrJDOFY8rtT
XnqOfkdq28Wg9CdEM2FaUB7goK2Ln0Djl/Xo5maYCmkC30G5l68c/RIzmqjRHYR2
xzgstGgWchUkYs8+z8GkUxGVTUKEBzt03B/X/aMyst6aYFp9GTofHuMi5YRPrAXU
lE8Omg9irl5z7XFiI4i0RmjIG030znR3gVj6BTJUpGdHNhvDeBFNDvd2sKpEjAUI
6NqxBXR4CbmgHoP6lUR55L/3lMyiDnxjSAeTPGbEfxtyQtff7Bo=
=C9y3
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)
|