From: roam@ringlet.net
On Sun, Aug 17, 2025 at 11:46:29PM +0300, Peter Pentchev wrote:
> On Sun, Aug 17, 2025 at 09:34:14PM +0100, Richard Lewis wrote:
> > "Theodore Ts'o" writes:
> >
> > > In some cases, if it's a patch sent via e-mail, I'll just fix up the
> > > patch and then let the contributor know that they failed to do error
> > > checking, or their patch had a buffer overrun and result in a security
> > > vulnerability etc. But with a merge request, all I can do is explain
> > > what they did wrong, and ask them to resubmit the merge request.
> >
> > Not looking to argue the main point (90% of everything is crud, and i
> > dont think anyone things every contribution must be accepted), but this
> > statement confused me: the merge request is already in git, so i dont
> > understand why people think it is harder to use than a patch attached to
> > an email? you can check out a merge request and amend or cherry pick
> > commits. you could even run git diff and pipe the result into a patch
> > and use whatever existing workflow works for the bts?
>
> ...but how do you then tell the Git forge to use your changes when
> you want to tell it to merge this merge request?
I mean, yes, if the merge request has been made from a different branch in
the same Git repository, so you actually have enough access to force-push
your changes to that branch, that might even be possible, but first, that's
not always the case, and second, even then that is not always easy and
convenient.
G'luck,
Peter
--
Peter Pentchev roam@ringlet.net roam@debian.org peter@morpheusly.com
PGP key: https://www.ringlet.net/roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEELuenpRf8EkzxFcNUZR7vsCUn3xMFAmiiQNMACgkQZR7vsCUn
3xMVkRAAxXnbsegeek3kKkzfesqloICbYbJGxNTGiW7DrVZIj9zrYZo8Ji1lMo+l
g0kgZ7iwhQMRYenrF/9DukQyt3usMldmfuygk6rk9ZnDV2YzysHbz2TBtPR4MZiy
PB1xKgmsF8SgJKaaDpvvKn1BFor73X49/DSNyXTO3E86pIMS0R7uCQzEzWL2TIhy
t4qRIMR7YZts/zupp28iLemYPqEB8pWNeS23IMvVDHmG5Y5M5SXSSJH/Dsi9UTcr
BPqLQnSwdazn1k70U8OiuHoeI4h6Q66UfkjhxsJ6bbie8L05zqrpSIvmX479Pe4E
HUNIY++eOgpLLG5fmPSEYpVg+hxHPLmx1+7wobGocNI/7FFT0asVFpwBj5xmMYp3
hzDYgS6pe7soc5FqpvTY52AWV6vEosmNmjhSlRXCozUMsZlHESTytW8SejBHwbno
XlosDReh9Q5cp5KbGSq56tE+aApNNVc1/9buvzp5VjDLUmj2ZVXd1FiLhakiQ7ux
pX5LX+n8bAe2isOlGpbRClHiHFQ6qpaX441slou2VKDo9v3oQk19iZo1dT4ekxX6
V1P2X4nXhjnjzCBgfTKIranKwqPsIYHV1WP1hrllCRhZw4LXmtB+3WsB3VxgVHJa
/72NA1wKCfeDFGY9NpVz4k9elPDxs7DRSn6YUae6+4tPxGJAynI=
=2Du3
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)
|