Just a sample of the Echomail archive
Cooperative anarchy at its finest, still active today. Darkrealms is the Zone 1 Hub.
| SYNC_PROGRAMMING | Synchronet/Baja/XSDK Programming | 49,116 messages |
[ << oldest | < older | list | newer > | newest >> ]
| Message 49,033 of 49,116 |
| SPACE(p); 3364 3365 if (*p = to = '-') { /* -Letc */ 3366 |
| FIND_WHITESPACE(p); 3367 |
| } /ftpsrvr.cpp: |
hread(void *)()
3360 }
3361
3362 p = cmd + 4;
3363 SKIP_WHITESPACE(p);
3364
3365 if (*p == '-') { /* -Letc */
>>> CID 643140: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
3366 FIND_WHITESPACE(p);
3367 SKIP_WHITESPACE(p);
3368 }
3369
3370 filespec = p;
3371 if (*filespec == 0)
/ftpsrvr.cpp: 3367 in ctrl_thread(void *)()
3361
3362 p = cmd + 4;
3363 SKIP_WHITESPACE(p);
3364
3365 if (*p == '-') { /* -Letc */
3366 FIND_WHITESPACE(p);
>>> CID 643140: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
3367 SKIP_WHITESPACE(p);
3368 }
3369
3370 filespec = p;
3371 if (*filespec == 0)
3372 filespec = "*";
/ftpsrvr.cpp: 3283 in ctrl_thread(void *)()
3277 sockprintf(sock, sess, "451 Insufficient system
storage");
3278 continue;
3279 }
3280 }
3281
3282 p = cmd + 4;
>>> CID 643140: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
3283 SKIP_WHITESPACE(p);
3284
3285 filespec = p;
3286 if (!local_dir[0])
3287 strcpy(local_dir, "/");
3288 SAFEPRINTF2(path, "%s%s", local_dir, filespec);
** CID 643139: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 1557 in ftpalias(char *, char *, user_t *, client_t *,
int *)()
/ftpsrvr.cpp: 1544 in ftpalias(char *, char *, user_t *, client_t *,
int *)()
________________________________________________________________
____________________________
*** CID 643139: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 1557 in ftpalias(char *, char *, user_t *, client_t
*, int *)()
1551 *tp = 0;
1552
1553 if (stricmp(p, alias)) /* Not a match */
1554 continue;
1555
1556 p = tp + 1; /* filename */
>>> CID 643139: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
1557 SKIP_WHITESPACE(p);
1558
1559 tp = p; /* terminator */
1560 FIND_WHITESPACE(tp);
1561 if (*tp)
1562 *tp = 0;
/ftpsrvr.cpp: 1544 in ftpalias(char *, char *, user_t *, client_t
*, int *)()
1538
1539 while (!feof(fp)) {
1540 if (!fgets(line, sizeof(line), fp))
1541 break;
1542
1543 p = line; /* alias */
>>> CID 643139: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
1544 SKIP_WHITESPACE(p);
1545 if (*p == ';') /* comment */
1546 continue;
1547
1548 tp = p; /* terminator */
1549 FIND_WHITESPACE(tp);
** CID 643138: (Y2K38_SAFETY)
/services.cpp: 2230 in services_thread()
/services.cpp: 2232 in services_thread()
________________________________________________________________
____________________________
*** CID 643138: (Y2K38_SAFETY)
/services.cpp: 2230 in services_thread()
2224 std::string most_active = connect_rate_limiter->
ost_active(&most_active_count);
2225 char str[sizeof rate_limit_report];
2226 char tmp[128], tmp2[128];
2227 snprintf(str, sizeof str, "Connect limiting current:
clients=%zu, requests=%zu, most-active=%s (%zu), highest: %s (%u) on %s,
limited: %u, last: %s on %s (repeat: %u)"
2228 , connect_rate_limiter->client_count(), connect
rate_limiter->total(), most_active.c_str(), most_active_count
2229 , connect_rate_limiter->currHighwater.client.c_str(),
connect_rate_limiter->currHighwater.count
>>> CID 643138: (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too
few bits to accommodate it. The expression "connect_rate_l
miter->currHighwater.time" is cast to "time32_t".
2230 , timestr(&scfg, (time32_t)connect_rate_limite
->currHighwater.time, tmp)
2231 , connect_rate_limiter->disallowed.load()
2232 , connect_rate_limiter->lastLimited.client.c_str(),
timestr(&scfg, (time32_t)connect_rate_limiter->lastLimited.time, tmp2)
2233 , connect_rate_limiter->repeat.load());
2234 if (strcmp(str, rate_limit_report) != 0) {
2235 SAFECOPY(rate_limit_report, str);
/services.cpp: 2232 in services_thread()
2226 char tmp[128], tmp2[128];
2227 snprintf(str, sizeof str, "Connect limiting current:
clients=%zu, requests=%zu, most-active=%s (%zu), highest: %s (%u) on %s,
limited: %u, last: %s on %s (repeat: %u)"
2228 , connect_rate_limiter->client_count(), connect
rate_limiter->total(), most_active.c_str(), most_active_count
2229 , connect_rate_limiter->currHighwater.client.c_str(),
connect_rate_limiter->currHighwater.count
2230 , timestr(&scfg, (time32_t)connect_rate_limite
->currHighwater.time, tmp)
2231 , connect_rate_limiter->disallowed.load()
>>> CID 643138: (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too
few bits to accommodate it. The expression "connect_rate_l
miter->lastLimited.time" is cast to "time32_t".
2232 , connect_rate_limiter->lastLimited.client.c_str(),
timestr(&scfg, (time32_t)connect_rate_limiter->lastLimited.time, tmp2)
2233 , connect_rate_limiter->repeat.load());
2234 if (strcmp(str, rate_limit_report) != 0) {
2235 SAFECOPY(rate_limit_report, str);
2236 lprintf(LOG_DEBUG, "%s", rate_limit_report);
2237 }
** CID 643137: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 4105 in ctrl_thread(void *)()
/ftpsrvr.cpp: 3782 in ctrl_thread(void *)()
________________________________________________________________
____________________________
*** CID 643137: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 4105 in ctrl_thread(void *)()
4099 tp = np; /* terminator pointer */
4100 FIND_WHITESPACE(tp);
4101 if (*tp)
4102 *tp = 0;
4103
4104 dp = tp + 1; /* description pointer */
>>> CID 643137: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*dp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
4105 SKIP_WHITESPACE(dp);
4106 truncsp(dp);
4107
4108 if (stricmp(dp, BBS_HIDDEN_ALIAS) == 0)
4109 continue;
4110
/ftpsrvr.cpp: 3782 in ctrl_thread(void *)()
3776 tp = np; /* terminator pointer */
3777 FIND_WHITESPACE(tp);
3778 if (*tp)
3779 *tp = 0;
3780
3781 dp = tp + 1; /* description pointer */
>>> CID 643137: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*dp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
3782 SKIP_WHITESPACE(dp);
3783 truncsp(dp);
3784
3785 if (stricmp(dp, BBS_HIDDEN_ALIAS) == 0)
3786 continue;
3787
** CID 643136: (Y2K38_SAFETY)
/ftpsrvr.cpp: 5417 in ftp_server()
/ftpsrvr.cpp: 5416 in ftp_server()
________________________________________________________________
____________________________
*** CID 643136: (Y2K38_SAFETY)
/ftpsrvr.cpp: 5417 in ftp_server()
5411 std::string most_active = request_rate_limiter->
ost_active(&most_active_count);
5412 char tmp[128], tmp2[128];
5413 snprintf(str, sizeof str, "Rate limiting current:
clients=%zu, requests=%zu, most-active=%s (%zu), highest: %s (%u) on %s,
limited: %u, last: %s on %s"
5414 , request_rate_limiter->client_count(), request
rate_limiter->total(), most_active.c_str(), most_active_count
5415 , request_rate_limiter->currHighwater.client.c_str(),
request_rate_limiter->currHighwater.count
5416 , timestr(&scfg, (time32_t)request_rate_limite
->currHighwater.time, tmp), request_rate_limiter->disallowed.load()
>>> CID 643136: (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too
few bits to accommodate it. The expression "request_rate_l
miter->lastLimited.time" is cast to "time32_t".
5417 , request_rate_limiter->lastLimited.client.c_str(),
timestr(&scfg, (time32_t)request_rate_limiter->lastLimited.time, tmp2));
5418 if (strcmp(str, rate_limit_report) != 0) {
5419 SAFECOPY(rate_limit_report, str);
5420 lprintf(LOG_DEBUG, "%s", rate_limit_report);
5421 }
5422 }
/ftpsrvr.cpp: 5416 in ftp_server()
5410 size_t most_active_count = 0;
5411 std::string most_active = request_rate_limiter->
ost_active(&most_active_count);
5412 char tmp[128], tmp2[128];
5413 snprintf(str, sizeof str, "Rate limiting current:
clients=%zu, requests=%zu, most-active=%s (%zu), highest: %s (%u) on %s,
limited: %u, last: %s on %s"
5414 , request_rate_limiter->client_count(), request
rate_limiter->total(), most_active.c_str(), most_active_count
5415 , request_rate_limiter->currHighwater.client.c_str(),
request_rate_limiter->currHighwater.count
>>> CID 643136: (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too
few bits to accommodate it. The expression "request_rate_l
miter->currHighwater.time" is cast to "time32_t".
5416 , timestr(&scfg, (time32_t)request_rate_limite
->currHighwater.time, tmp), request_rate_limiter->disallowed.load()
5417 , request_rate_limiter->lastLimited.client.c_str(),
timestr(&scfg, (time32_t)request_rate_limiter->lastLimited.time, tmp2));
5418 if (strcmp(str, rate_limit_report) != 0) {
5419 SAFECOPY(rate_limit_report, str);
5420 lprintf(LOG_DEBUG, "%s", rate_limit_report);
5421 }
** CID 643135: Program hangs (LOCK)
/services.cpp: 2476 in services_thread()
________________________________________________________________
____________________________
*** CID 643135: Program hangs (LOCK)
/services.cpp: 2476 in services_thread()
2470 close_socket(client_socket);
2471 continue;
2472 }
2473
2474 if (!host_exempt->listed(host_ip, nullptr)) {
2475 login_attempt_t attempted;
>>> CID 643135: Program hangs (LOCK)
>>> "loginBanned" locks "startup->
login_attempt_list->mutex" while it is locked.
2476 ulong banned = loginBanned(&scfg, s
artup->login_attempt_list, client_socket, /* host_name: */ NULL,
startup->login_attempt, &attempted);
2477 if (banned) {
2478 char ban_duration[128];
2479 lprintf(LOG_NOTICE, "%04d [%s] !TEMPORARY BAN (%lu login
attempts, last: %s) - remaining: %s"
2480 , client_socket, host_ip, attempted.count - attempted.dupes,
attempted.user
2481 , duration_estimate_to_str(banned, ban_duration, sizeof
ban_duration, 1, 1));
** CID 643134: Uninitialized members (UNINIT_CTOR)
/filterfile.hpp: 44 in filterFile::filterFile()()
________________________________________________________________
____________________________
*** CID 643134: Uninitialized members (UNINIT_CTOR)
/filterfile.hpp: 44 in filterFile::filterFile()()
38 filterFile() = default;
39 ~filterFile() {
40 strListFree(&list);
41 }
42 std::atomic<uint> fread_count{};
43 std::atomic<uint> total_found{};
>>> CID 643134: Uninitialized members (UNINIT_CTOR)
>>> The compiler-generated constructor for this class does not
initialize "fchk_interval".
44 time_t fchk_interval; // seconds
45 char fname[MAX_PATH + 1];
46 bool listed(const char* str1, const char* str2 = nullptr, struct
trash* details = nullptr) {
47 bool result;
48 time_t now = time(nullptr);
49 if (fchk_interval) {
** CID 643133: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 4476 in ctrl_thread(void *)()
/ftpsrvr.cpp: 4473 in ctrl_thread(void *)()
/ftpsrvr.cpp: 4097 in ctrl_thread(void *)()
/ftpsrvr.cpp: 3774 in ctrl_thread(void *)()
________________________________________________________________
____________________________
*** CID 643133: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 4476 in ctrl_thread(void *)()
4470 *tp = 0;
4471
4472 np = tp + 1; /* filename pointer */
4473 SKIP_WHITESPACE(np);
4474
4475 np++; /* description pointer */
>>> CID 643133: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*np == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
4476 FIND_WHITESPACE(np);
4477
4478 while (*np && *np < ' ') np++;
4479
4480 truncsp(np);
4481
/ftpsrvr.cpp: 4473 in ctrl_thread(void *)()
4467 tp = p; /* terminator pointer */
4468 FIND_WHITESPACE(tp);
4469 if (*tp)
4470 *tp = 0;
4471
4472 np = tp + 1; /* filename pointer */
>>> CID 643133: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*np == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
4473 SKIP_WHITESPACE(np);
4474
4475 np++; /* description pointer */
4476 FIND_WHITESPACE(np);
4477
4478 while (*np && *np < ' ') np++;
/ftpsrvr.cpp: 4097 in ctrl_thread(void *)()
4091 tp = p; /* terminator pointer */
4092 FIND_WHITESPACE(tp);
4093 if (*tp)
4094 *tp = 0;
4095
4096 np = tp + 1; /* filename pointer */
>>> CID 643133: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*np == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
4097 SKIP_WHITESPACE(np);
4098
4099 tp = np; /* terminator pointer */
4100 FIND_WHITESPACE(tp);
4101 if (*tp)
4102 *tp = 0;
/ftpsrvr.cpp: 3774 in ctrl_thread(void *)()
3768 tp = p; /* terminator pointer */
3769 FIND_WHITESPACE(tp);
3770 if (*tp)
3771 *tp = 0;
3772
3773 np = tp + 1; /* filename pointer */
>>> CID 643133: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*np == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
3774 SKIP_WHITESPACE(np);
3775
3776 tp = np; /* terminator pointer */
3777 FIND_WHITESPACE(tp);
3778 if (*tp)
3779 *tp = 0;
** CID 643132: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 1560 in ftpalias(char *, char *, user_t *, client_t *,
int *)()
/ftpsrvr.cpp: 1549 in ftpalias(char *, char *, user_t *, client_t *,
int *)()
________________________________________________________________
____________________________
*** CID 643132: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 1560 in ftpalias(char *, char *, user_t *, client_t
*, int *)()
1554 continue;
1555
1556 p = tp + 1; /* filename */
1557 SKIP_WHITESPACE(p);
1558
1559 tp = p; /* terminator */
>>> CID 643132: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
1560 FIND_WHITESPACE(tp);
1561 if (*tp)
1562 *tp = 0;
1563
1564 if (filename == NULL /* CWD? */ && (*lastchar(p) !=
'/' || (*fname != 0 && strcmp(fname, alias)))) {
1565 fclose(fp);
/ftpsrvr.cpp: 1549 in ftpalias(char *, char *, user_t *, client_t
*, int *)()
1543 p = line; /* alias */
1544 SKIP_WHITESPACE(p);
1545 if (*p == ';') /* comment */
1546 continue;
1547
1548 tp = p; /* terminator */
>>> CID 643132: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
1549 FIND_WHITESPACE(tp);
1550 if (*tp)
1551 *tp = 0;
1552
1553 if (stricmp(p, alias)) /* Not a match */
1554 continue;
** CID 643131: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 3769 in ctrl_thread(void *)()
/ftpsrvr.cpp: 3777 in ctrl_thread(void *)()
/ftpsrvr.cpp: 4100 in ctrl_thread(void *)()
/ftpsrvr.cpp: 4092 in ctrl_thread(void *)()
/ftpsrvr.cpp: 4468 in ctrl_thread(void *)()
________________________________________________________________
____________________________
*** CID 643131: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.cpp: 3769 in ctrl_thread(void *)()
3763 SKIP_WHITESPACE(p);
3764
3765 if (*p == ';') /* comment */
3766 continue;
3767
3768 tp = p; /* terminator pointer */
>>> CID 643131: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
3769 FIND_WHITESPACE(tp);
3770 if (*tp)
3771 *tp = 0;
3772
3773 np = tp + 1; /* filename pointer */
3774 SKIP_WHITESPACE(np);
/ftpsrvr.cpp: 3777 in ctrl_thread(void *)()
3771 *tp = 0;
3772
3773 np = tp + 1; /* filename pointer */
3774 SKIP_WHITESPACE(np);
3775
3776 tp = np; /* terminator pointer */
>>> CID 643131: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
3777 FIND_WHITESPACE(tp);
3778 if (*tp)
3779 *tp = 0;
3780
3781 dp = tp + 1; /* description pointer */
3782 SKIP_WHITESPACE(dp);
/ftpsrvr.cpp: 4100 in ctrl_thread(void *)()
4094 *tp = 0;
4095
4096 np = tp + 1; /* filename pointer */
4097 SKIP_WHITESPACE(np);
4098
4099 tp = np; /* terminator pointer */
>>> CID 643131: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
4100 FIND_WHITESPACE(tp);
4101 if (*tp)
4102 *tp = 0;
4103
4104 dp = tp + 1; /* description pointer */
4105 SKIP_WHITESPACE(dp);
/ftpsrvr.cpp: 4092 in ctrl_thread(void *)()
4086 SKIP_WHITESPACE(p);
4087
4088 if (*p == ';') /* comment */
4089 continue;
4090
4091 tp = p; /* terminator pointer */
>>> CID 643131: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
4092 FIND_WHITESPACE(tp);
4093 if (*tp)
4094 *tp = 0;
4095
4096 np = tp + 1; /* filename pointer */
4097 SKIP_WHITESPACE(np);
/ftpsrvr.cpp: 4468 in ctrl_thread(void *)()
4462 SKIP_WHITESPACE(p);
4463
4464 if (*p == ';') /* comment */
4465 continue;
4466
4467 tp = p; /* terminator pointer */
>>> CID 643131: (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is
always false regardless of the values of its operands. This occurs as the
logical second operand of "||".
4468 FIND_WHITESPACE(tp);
4469 if (*tp)
4470 *tp = 0;
4471
4472 np = tp + 1; /* filename pointer */
4473 SKIP_WHITESPACE(np);
** CID 643130: Error handling issues (CHECKED_RETURN)
/ftpsrvr.cpp: 929 in receive_thread(void *)()
________________________________________________________________
____________________________
*** CID 643130: Error handling issues (CHECKED_RETURN)
/ftpsrvr.cpp: 929 in receive_thread(void *)()
923
924 *xfer.aborted = FALSE;
925 if (xfer.filepos || startup->options & FTP_OPT_DEBUG_DATA)
926 lprintf(LOG_DEBUG, "%04d <%s> DATA socket %d receiving %s
from offset %" PRIdOFF
927 , xfer.ctrl_sock, xfer.user->alias, *xfer.data_sock,
xfer.filename, xfer.filepos);
928
>>> CID 643130: Error handling issues (CHECKED_RETURN)
>>> Calling "fseeko(fp, xfer.filepos, 0)" without
checking return value. This library function may fail and return an error code.
929 fseeko(fp, xfer.filepos, SEEK_SET);
930
931 // Determine the maximum file size to allow, accounting for minimum
free space
932 char path[MAX_PATH + 1];
933 SAFECOPY(path, xfer.filename);
934 *getfname(path) = '\0';
** CID 643129: (Y2K38_SAFETY)
/mailsrvr.cpp: 6497 in mail_server()
/mailsrvr.cpp: 6496 in mail_server()
________________________________________________________________
____________________________
*** CID 643129: (Y2K38_SAFETY)
/mailsrvr.cpp: 6497 in mail_server()
6491 std::string most_active = request_rate_limiter->
ost_active(&most_active_count);
6492 char tmp[128], tmp2[128];
6493 snprintf(str, sizeof str, "Rate limiting current;
clients=%zu, requests=%zu, most-active=%s (%zu), highest: %s (%u) on %s,
limited: %u, last: %s on %s"
6494 , request_rate_limiter->client_count(), request
rate_limiter->total(), most_active.c_str(), most_active_count
6495 , request_rate_limiter->currHighwater.client.c_str(),
request_rate_limiter->currHighwater.count
6496 , timestr(&scfg, (time32_t)request_rate_limite
->currHighwater.time, tmp), request_rate_limiter->disallowed.load()
>>> CID 643129: (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too
few bits to accommodate it. The expression "request_rate_l
miter->lastLimited.time" is cast to "time32_t".
6497 , request_rate_limiter->lastLimited.client.c_str(),
timestr(&scfg, (time32_t)request_rate_limiter->lastLimited.time, tmp2));
6498 if (strcmp(str, rate_limit_report) != 0) {
6499 SAFECOPY(rate_limit_report, str);
6500 lprintf(LOG_DEBUG, "%s", rate_limit_report);
6501 }
6502 }
/mailsrvr.cpp: 6496 in mail_server()
6490 size_t most_active_count = 0;
6491 std::string most_active = request_rate_limiter->
ost_active(&most_active_count);
6492 char tmp[128], tmp2[128];
6493 snprintf(str, sizeof str, "Rate limiting current;
clients=%zu, requests=%zu, most-active=%s (%zu), highest: %s (%u) on %s,
limited: %u, last: %s on %s"
6494 , request_rate_limiter->client_count(), request
rate_limiter->total(), most_active.c_str(), most_active_count
6495 , request_rate_limiter->currHighwater.client.c_str(),
request_rate_limiter->currHighwater.count
>>> CID 643129: (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too
few bits to accommodate it. The expression "request_rate_l
miter->currHighwater.time" is cast to "time32_t".
6496 , timestr(&scfg, (time32_t)request_rate_limite
->currHighwater.time, tmp), request_rate_limiter->disallowed.load()
6497 , request_rate_limiter->lastLimited.client.c_str(),
timestr(&scfg, (time32_t)request_rate_limiter->lastLimited.time, tmp2));
6498 if (strcmp(str, rate_limit_report) != 0) {
6499 SAFECOPY(rate_limit_report, str);
6500 lprintf(LOG_DEBUG, "%s", rate_limit_report);
6501 }
Best regards, The Coverity Scan Admin Team 
|