Just a sample of the Echomail archive
Cooperative anarchy at its finest, still active today. Darkrealms is the Zone 1 Hub.
| SYNC_PROGRAMMING | Synchronet/Baja/XSDK Programming | 49,116 messages |
[ << oldest | < older | list | newer > | newest >> ]
| Message 48,836 of 49,116 |
| scan-admin@coverity.com to All |
| New Defects reported by Coverity Scan fo |
| 28 Jan 26 13:46:25 |
TZUTC: 0000
MSGID: 54271.syncprog@1:103/705 2de01d32
PID: Synchronet 3.21b-Linux master/5c73d262c Jan 21 2026 GCC 12.2.0
TID: SBBSecho 3.35-Linux master/0958ba161 Jan 25 2026 GCC 12.2.0
BBSID: VERT
CHRS: ASCII 1
FORMAT: flowed
----==_mimepart_697a13306f491_cf6782d0dbe50d9a0894b
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hi,
Please find the latest report on new defect(s) introduced to Synchronet found
with Coverity Scan.
3 new defect(s) introduced to Synchronet found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 642982: (FORWARD_NULL)
/prntfile.cpp: 263 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
________________________________________________________________
____________________________
*** CID 642982: (FORWARD_NULL)
/prntfile.cpp: 263 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
257 default:
258 case TERM_KEY_DOWN:
259 nextline = line + 1;
260 break;
261 }
262 if (nextline != line + 1 && nextline < lines)
>>> CID 642982: (FORWARD_NULL)
>>> Dereferencing null pointer "offset".
263 fseeko(stream, offset[nextline], 0);
264 line = nextline;
265 }
266 else
267 ++line;
268 }
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
222 else
223 nextline = line - (((term->rows - 1) * 2) - 1);
224 break;
225 case TERM_KEY_END:
226 {
227 bputs(text[SeekingFile]);
>>> CID 642982: (FORWARD_NULL)
>>> Dereferencing null pointer "offset".
228 fseeko(stream, offset[lines - 1], SEEK_SET);
229 if (fgets(buf, length + 1, stream) == NULL)
230 break;
231 off_t lastline = lines - 1;
232 while (!feof(stream) && !msgabort()) {
233 o = ftello(stream);
** CID 642981: Error handling issues (CHECKED_RETURN)
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
________________________________________________________________
____________________________
*** CID 642981: Error handling issues (CHECKED_RETURN)
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
222 else
223 nextline = line - (((term->rows - 1) * 2) - 1);
224 break;
225 case TERM_KEY_END:
226 {
227 bputs(text[SeekingFile]);
>>> CID 642981: Error handling issues (CHECKED_RETURN)
>>> Calling "fseeko(stream, offset[lines - 1UL], 0)" without checking
return value. This library function may fail and return an error code.
228 fseeko(stream, offset[lines - 1], SEEK_SET);
229 if (fgets(buf, length + 1, stream) == NULL)
230 break;
231 off_t lastline = lines - 1;
232 while (!feof(stream) && !msgabort()) {
233 o = ftello(stream);
** CID 642980: Integer handling issues (INTEGER_OVERFLOW)
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
________________________________________________________________
____________________________
*** CID 642980: Integer handling issues (INTEGER_OVERFLOW)
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
222 else
223 nextline = line - (((term->rows - 1) * 2) - 1);
224 break;
225 case TERM_KEY_END:
226 {
227 bputs(text[SeekingFile]);
>>> CID 642980: Integer handling issues (INTEGER_OVERFLOW)
>>> Expression "lines - 1UL", where "lines" is known to be equal to 0,
underflows the type of "lines - 1UL", which is type "unsigned long".
228 fseeko(stream, offset[lines - 1], SEEK_SET);
229 if (fgets(buf, length + 1, stream) == NULL)
230 break;
231 off_t lastline = lines - 1;
232 while (!feof(stream) && !msgabort()) {
233 o = ftello(stream);
________________________________________________________________
_______________________________________
To view the defects in Coverity Scan visit, https://scan.coverit
.com/projects/synchronet?tab=overview
----==_mimepart_697a13306f491_cf6782d0dbe50d9a0894b
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit
Defect Details
** CID 642982: (FORWARD_NULL)
/prntfile.cpp: 263 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
________________________________________________________________
____________________________
*** CID 642982: (FORWARD_NULL)
/prntfile.cpp: 263 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
257 default:
258 case TERM_KEY_DOWN:
259 nextline = line + 1;
260 break;
261 }
262 if (nextline != line + 1 && nextline < lines)
>>> CID 642982: (FORWARD_NULL)
>>> Dereferencing null pointer "offset".
263 fseeko(stream, offset[nextline], 0);
264 line = nextline;
265 }
266 else
267 ++line;
268 }
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
222 else
223 nextline = line - (((term->rows - 1) * 2) - 1);
224 break;
225 case TERM_KEY_END:
226 {
227 bputs(text[SeekingFile]);
>>> CID 642982: (FORWARD_NULL)
>>> Dereferencing null pointer "offset".
228 fseeko(stream, offset[lines - 1], SEEK_SET);
229 if (fgets(buf, length + 1, stream) == NULL)
230 break;
231 off_t lastline = lines - 1;
232 while (!feof(stream) && !msgabort()) {
233 o = ftello(stream);
** CID 642981: Error handling issues (CHECKED_RETURN)
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
________________________________________________________________
____________________________
*** CID 642981: Error handling issues (CHECKED_RETURN)
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
222 else
223 nextline = line - (((term->rows - 1) * 2) - 1);
224 break;
225 case TERM_KEY_END:
226 {
227 bputs(text[SeekingFile]);
>>> CID 642981: Error handling issues (CHECKED_RETURN)
>>> Calling "fseeko(stream, offset[lines - 1UL], 0)"
without checking return value. This library function may fail and return an
error code.
228 fseeko(stream, offset[lines - 1], SEEK_SET);
229 if (fgets(buf, length + 1, stream) == NULL)
230 break;
231 off_t lastline = lines - 1;
232 while (!feof(stream) && !msgabort()) {
233 o = ftello(stream);
** CID 642980: Integer handling issues (INTEGER_OVERFLOW)
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
________________________________________________________________
____________________________
*** CID 642980: Integer handling issues (INTEGER_OVERFLOW)
/prntfile.cpp: 228 in sbbs_t::printfile(const char *, int, int,
JSObject *)()
222 else
223 nextline = line - (((term->rows - 1) * 2) - 1);
224 break;
225 case TERM_KEY_END:
226 {
227 bputs(text[SeekingFile]);
>>> CID 642980: Integer handling issues (I
TEGER_OVERFLOW)
>>> Expression "lines - 1UL", where "lines"
is known to be equal to 0, underflows the type of "lines - 1UL",
which is type "unsigned long".
228 fseeko(stream, offset[lines - 1], SEEK_SET);
229 if (fgets(buf, length + 1, stream) == NULL)
230 break;
231 off_t lastline = lines - 1;
232 while (!feof(stream) && !msgabort()) {
233 o = ftello(stream);
Best regards, The Coverity Scan Admin Team 
----==_mimepart_697a13306f491_cf6782d0dbe50d9a0894b--
--- SBBSecho 3.35-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
SEEN-BY: 103/705 105/81 106/201 124/5016 128/187 129/14 153/757 7715
SEEN-BY: 154/10 30 110 203/0 218/700 221/0 226/30 227/114 229/110
SEEN-BY: 229/134 206 317 400 426 428 470 700 705 240/1120 5832 263/1
SEEN-BY: 266/512 280/464 5003 5006 291/111 292/8125 301/1 320/219
SEEN-BY: 322/757 341/66 234 342/200 396/45 423/120 460/58 256 1124
SEEN-BY: 633/280 712/848 770/1 902/26 5020/400 8912 5054/30 5075/35
PATH: 103/705 280/464 460/58 229/426
|
(c) 1994, bbs@darkrealms.ca