TZUTC: 0000   
   MSGID: 51976.syncprog@1:103/705 2c3501c5   
   PID: Synchronet 3.20e-Linux master/cc717b402 Mar 08 2025 GCC 12.2.0   
   TID: SBBSecho 3.23-Linux master/cc717b402 Mar 08 2025 GCC 12.2.0   
   BBSID: VERT   
   CHRS: ASCII 1   
   Hi,   
      
   Please find the latest report on new defect(s) introduced to Synchronet found   
   with Coverity Scan.   
      
   1 new defect(s) introduced to Synchronet found with Coverity Scan.   
   3 defect(s), reported by Coverity Scan earlier, were marked fixed in the   
   recent build analyzed by Coverity Scan.   
      
   New defect(s) Reported-by: Coverity Scan   
   Showing 1 of 1 defect(s)   
      
      
   ** CID 544155:  Error handling issues  (CHECKED_RETURN)   
   /ssl.c: 540 in get_ssl_cert()   
      
      
   ________________________________________________________________   
   _______________________________________   
   *** CID 544155:  Error handling issues  (CHECKED_RETURN)   
   /ssl.c: 540 in get_ssl_cert()   
   534     	size_t backoff_ms = 1;   
   535     	unsigned loops = 0;   
   536     	while (cert_entry->cert == -1) {   
   537     		assert_pthread_mutex_lock(&get_ssl_cert_mutex);   
   538     		/* Get the certificate... first try loading it from a file... */   
   539     		if (cryptStatusOK(cryptKeysetOpen(&ssl_keyset, CRYPT_UNUSED,   
   CRYPT_KEYSET_FILE, cert_path, CRYPT_KEYOPT_READONLY))) {   
   >>>     CID 544155:  Error handling issues  (CHECKED_RETURN)   
   >>>     Calling "log_cryptlib_error" without checking return value (as is done   
   elsewhere 16 out of 17 times).   
   540     			DO("getting private key", ssl_keyset, cryptGetPrivate   
   ey(ssl_keyset, &cert_entry->cert, CRYPT_KEYID_NAME, "ssl_cert",    
   fg->sys_pass));   
   541     			cryptKeysetClose(ssl_keyset);   
   542     		}   
   543     		if (cert_entry->cert == -1) {   
   544     			lprintf(LOG_WARNING, "Failed to open/read TLS certificate: %s",   
   cert_path);   
   545     			if (cfg->create_self_signed_cert) {   
      
      
   ________________________________________________________________   
   _______________________________________   
   To view the defects in Coverity Scan visit, https://scan.coverit   
   .com/projects/synchronet?tab=overview   
      
      
   --- SBBSecho 3.23-Linux   
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)   
   SEEN-BY: 10/0 1 102/401 103/1 705 105/81 106/201 124/5016 128/187   
   SEEN-BY: 153/7715 154/110 214/22 218/0 1 215 700 810 226/30 227/114   
   SEEN-BY: 229/110 114 206 317 400 426 428 470 550 700 705 266/512 280/464   
   SEEN-BY: 291/111 301/1 320/219 322/757 342/200 396/45 460/58 633/280   
   SEEN-BY: 712/848 902/26 5075/35   
   PATH: 103/705 218/700 229/426