REPLY: 2:240/8002@fidonet 5a68b866   
   MSGID: 1:320/219@fidonet 65ba763d   
   CHRS: UTF-8 2   
   TZUTC: -0500   
   TID: MBSE-FIDO 1.0.8.4 (Linux-x86_64)   
   Hello Niels!   
      
   31 Jan 24 07:37, you wrote to all:   
      
    NH> Hello, MBSE Developer Team,   
      
    NH> I have found and fixed an error with the 'HelP' window shown in the   
    NH> internal editor, which causes the editor to crash:   
      
    NH> 1.) Steps to reproduce:   
    NH> - Enter a message in the internal editor   
    NH> - In the editor, press and then to display the help text   
    NH> window - Press a key to close the help text window - Try to continue   
    NH> to edit the message text -> an error message appears, then the BBS   
    NH> disconnects   
      
    NH> 2.) Root cause analysis:   
    NH> - The function "void Full_Help(void)" in fsedit.c utilizes several   
    NH> helper functions to draw the help-text window. These helper functions   
    NH> access and manipulate the gobal variables "int Col" and "int Row"   
    NH> causing an overflow of the "Row" variable. This overflow will lead to   
    NH> a Segfault when "Refresh()" function is called before resuming editing   
    NH> of the text.   
      
    NH> 3.) Solution:   
    NH> - i've added tow local variables "int hc" and "int hr" to the   
    NH> function "void Full_Help(void)" which are being used to temporary   
    NH> store the original values if "int Col" and "int Row" at the beginning   
    NH> of the function before drawing the help-text window. Once this is   
    NH> drawn, "int Col" and "int Row" are being assigned the original values   
    NH> temporarily stored in "int hc" and "int hr". That way, the call to   
    NH> "Refresh()" after drawing the help-text window will no longer crash   
    NH> and operate as intended.   
      
    NH> Do you want me to create a MR for this fix?   
      
   Please submit a diff to me at 1:320/219. Thank you for your detailed bug    
   report and fix.   
      
   Regards,   
      
   Andrew   
   MBSE Development Team   
      
   --- GoldED+/LNX 1.1.5-b20230826   
    * Origin: Phoenix BBS * phoenix.bnbbbs.net (1:320/219)   
   SEEN-BY: 1/19 15/0 16/0 18/200 19/37 80/1 90/1 105/81 106/201 123/130   
   SEEN-BY: 128/260 129/305 135/225 142/104 153/7715 203/0 218/700 221/0   
   SEEN-BY: 226/30 227/114 229/110 112 113 206 307 317 400 426 428 470   
   SEEN-BY: 229/550 664 700 240/5832 266/512 282/1038 291/111 292/854   
   SEEN-BY: 320/119 219 319 2119 322/757 342/200 396/45 460/58 633/280   
   SEEN-BY: 712/848 5020/400 5075/35   
   PATH: 320/219 229/426   
      
|