home  bbs  files  messages ]

      ZZLI4422             linux.debian.devel             1179 messages      

[ previous | next | reply ]

[ list messages | list forums ]

  Msg # 972 of 1179 on ZZLI4422, Sunday 8-16-25, 6:21  
  From: RUSS ALLBERY  
  To: OTTO@DEBIAN.ORG  
  Subj: Re: debian/watch version 5 (2/2)  
 [continued from previous message] 
  
 experienced developers, who are not that interested in being told what 
 workflow they should be using and are more interested in how to gradually 
 add specific tools in a way that doesn't badly increase the level of 
 friction involved in their current work. That advice will probably need to 
 be at least somewhat tailored to how they're currently working and their 
 preferences, as opposed to how you wish they were working or how you 
 prefer to work yourself. 
  
 Anyway, the tl;dr is that I have worked on teams before where code review 
 was required for every change, and that workflow was both annoying and 
 resulted in lower-quality code reviews when they actually mattered. I'm 
 not likely to use it again without a really good justification for why a 
 specific project needs that level of overhead and friction. This does not 
 mean that I dislike code review! I both ask for and write code reviews on 
 a regular basis and they're valuable for thinking more deeply about tricky 
 bits of code. They're also valuable as a training tool for developers who 
 are new to a particular code base. We should use them where appropriate, 
 including for new contributors. But we shouldn't turn them into an 
 off-putting religion. 
  
 -- 
 Russ Allbery (rra@debian.org)               
  
 --- SoupGate-Win32 v1.05 
  * Origin: you cannot sedate... all the things you hate (1:229/2) 

[ list messages | list forums | previous | next | reply ]

search for:

328,107 visits
(c) 1994,  bbs@darkrealms.ca