home  bbs  files  messages ]

      ZZLI4422             linux.debian.devel             1179 messages      

[ previous | next | reply ]

[ list messages | list forums ]

  Msg # 12 of 1179 on ZZLI4422, Tuesday 8-18-25, 12:33  
  From: THEODORE TS'O  
  To: ALL  
  Subj: Re: Please check open Merge Requests bef  
 From: tytso@mit.edu 
  
 On Sun, Aug 17, 2025 at 02:44:06PM -0700, Otto Kek€l€inen wrote: 
 > In the web interface you can suggest changes that automatically become 
 > patches on the branch, which the original submitter can easily clean 
 > up / integrate next time they rebase/refresh the MR. 
  
 My point was that it takes a lot more effort, and time, to tell the 
 submitter what to change, and then (a) wait for them to make the 
 change, and (b) hope they make the change correctly.  If they don't 
 then you have to repeat, possily multiple times. 
  
 You could just make the change yourself, and then do a "git commit 
 --amend", but then the MR won't get closed automatically, becaue the 
 forge won't recognize the modified commit.  And if you do a "git 
 commit" instead ofa "git commit --amend", then you break bisectibility 
 of the git tree. 
  
 Yes, you could then close the commit manually, but now it's more work 
 than the e-mail based workflow. 
  
 If you use b4[1] as part of the e-mail based workflow, BTW, and you 
 modify the patch submitted using "git commit", b4's auto-thankanator 
 ("b4 ty") is smart enough to detect modified commits and associate 
 them with the acknowledgement.  So this is something that github and 
 Salsa could do better, but right now... they don't. 
  
 [1] https://b4.docs.kernel.org/en/latest/ 
  
 Cheers, 
  
       - Ted 
  
 --- SoupGate-Win32 v1.05 
  * Origin: you cannot sedate... all the things you hate (1:229/2) 

[ list messages | list forums | previous | next | reply ]

search for:

328,084 visits
(c) 1994,  bbs@darkrealms.ca