home  bbs  files  messages ]

      ZZLI4422             linux.debian.devel             1179 messages      

[ previous | next | reply ]

[ list messages | list forums ]

  Msg # 1016 of 1179 on ZZLI4422, Monday 8-17-25, 6:31  
  From: RICHARD LEWIS  
  To: PETER PENTCHEV  
  Subj: Re: Please check open Merge Requests bef  
 From: richard.lewis.debian@googlemail.com 
  
 Peter Pentchev  writes: 
  
 > On Sun, Aug 17, 2025 at 09:34:14PM +0100, Richard Lewis wrote: 
 >> "Theodore Ts'o"  writes: 
 >> 
 >> > In some cases, if it's a patch sent via e-mail, I'll just fix up the 
 >> > patch and then let the contributor know that they failed to do error 
 >> > checking, or their patch had a buffer overrun and result in a security 
 >> > vulnerability etc.  But with a merge request, all I can do is explain 
 >> > what they did wrong, and ask them to resubmit the merge request. 
 >> 
 >> Not looking to argue the main point (90% of everything is crud, and i 
 >> dont think anyone things every contribution must be accepted), but this 
 >> statement confused me: the merge request is already in git, so i dont 
 >> understand why people think it is harder to use than a patch attached to 
 >> an email? you can check out a merge request and amend or cherry pick 
 >> commits. you could even run git diff and pipe the result into a patch 
 >> and use whatever existing workflow works for the bts? 
 > 
 > ...but how do you then tell the Git forge to use your changes when 
 > you want to tell it to merge this merge request? 
  
 i think you would just use git merge and git push etc from a command 
 line like any other branch. (i assume deleting the merge-request branch 
 from the command-line would close the MR, but maybe you need to use some 
 salsa api instead) 
  
 --- SoupGate-Win32 v1.05 
  * Origin: you cannot sedate... all the things you hate (1:229/2) 

[ list messages | list forums | previous | next | reply ]

search for:

328,121 visits
(c) 1994,  bbs@darkrealms.ca