From: owner@bugs.debian.org
This is a multi-part message in MIME format...
Your message dated Thu, 09 Oct 2025 00:20:07 +0000
with message-id
and subject line Bug#1117594: fixed in openssh 1:10.1p1-2
has caused the Debian Bug report #1117594,
regarding openssh: Connection sharing is very sluggish.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
1117594: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1117594
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
Received: (at submit) by bugs.debian.org; 8 Oct 2025 21:11:14 +0000
X-Spam-Checker-Version: SpamAssassin 4.0.1-bugs.debian.org_2005_01_02
(2024-03-25) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-16.0 required=4.0 tests=BAYES_00,
BODY_INCLUDES_PACKAGE,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,
DKIM_VALID_EF,FOURLA,HAS_PACKAGE,MD5_SHA1_SUM,RCVD_IN_DNSWL_MED,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,
RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham
autolearn_force=no version=4.0.1-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 59; hammy, 148; neutral, 87; spammy,
2. spammytokens:0.998-1--espoo, 0.998-1--Espoo
hammytokens:0.000-+--H*Ad:N*Sebastian, 0.000-+--H*F:N*Sebastian,
0.000-+--H*F:U*sebastian, 0.000-+--H*F:D*breakpoint.cc,
0.000-+--H*RU:sk:chamill
Return-path:
Received: from chamillionaire.breakpoint.cc ([91.216.245.30]:56570)
by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_X25519__RSA_P
S_RSAE_SHA256__AES_256_GCM:256)
(Exim 4.96)
(envelope-from )
id 1v6bRI-003Mz5-03
for submit@bugs.debian.org;
Wed, 08 Oct 2025 21:11:13 +0000
Date: Wed, 8 Oct 2025 23:11:06 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breakpoint.cc;
s=2025; t=1759957867;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type;
bh=v9TSTqHce2EE2A5EZLBQk+oudpDESkdrw+JS/P94jEg=;
b=Dv45Boyo3f5eFlfNUC/CXYiYrIvpMNXE1j+0Z1V1NRxKlYOmQyo4p1frnaxPewanB7geYI
XWcmkeS8F3XQshi5EL55Urzvog0JdpvL/uoF3AY69k3gq25WIny3FK3NYG8DDWw1DbE/yz
jviQBYEmKKaKWc2l6e8IPQQhjciMnbqYCYLDihw1Bj4Ys8GIM57PWuW7kXfxdRmQvn8g9J
qGWx/FYSWxKRX5Gvnn4JMixDgP/VwdTEsxOgJOhIIQoZurjb+QheysKv2evYP9aUPNCbus
jIZl32yPNcbdCN1k4LVFxr7fGPssX+GBsfoD4vxoC9Jk7z57CyZyCDhenhVRxA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=breakpoint.cc;
s=2025e; t=1759957867;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type;
bh=v9TSTqHce2EE2A5EZLBQk+oudpDESkdrw+JS/P94jEg=;
b=Z0SBC7W3mLWe1XyhBn65ZmAHshQeNt0fo7O04oElS5VvFfD1g+CQ9eNjuMI0OKguBXs12+
7PJu2vwIexdIUPDw==
From: Sebastian Andrzej Siewior
To: submit@bugs.debian.org
Subject: openssh: Connection sharing is very sluggish.
Message-ID: <20251008211106.ZY5hCdxu@breakpoint.cc>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="fkBVQ97tIBAOvEts"
Content-Disposition: inline
Delivered-To: submit@bugs.debian.org
--fkBVQ97tIBAOvEts
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Package: src:openssh
Version: 1:10.1p1-1
Severity: serious
Tags: upstream fixed-upstream patch
control: forwarded -1 https://bugzilla.mindrot.org/show_bug.cgi?id=3872
Since the 10.1p1 connection sharing (ssh -M, ControlMaster yes) is very
sluggish. It turns to be a openssh regression that is already fixed as
of commit beae06f56e0d0 ("upstream: don't reuse c->isatty for signalling
that the remote channel") in the portable tree. Please find attached the
patch.
Since I have it almost always enabled, especially for long distance
connection, I can't use it. Hence the severity.
Sebastian
--fkBVQ97tIBAOvEts
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
filename="upstream-don-t-reuse-c-isatty-for-signalling-that-th.patch"
From beae06f56e0d0a66ca535896149d5fb0b2e8a1b4 Mon Sep 17 00:00:00 2001
From: "djm@openbsd.org"
Date: Tue, 7 Oct 2025 08:02:32 +0000
Subject: [PATCH] upstream: don't reuse c->isatty for signalling that the
remote channel
has a tty attached as this causes side effects, e.g. in
channel_handle_rfd().
bz3872
ok markus@
OpenBSD-Commit-ID: 4cd8a9f641498ca6089442e59bad0fd3dcbe85f8
---
channels.c | 9 +++++----
channels.h | 3 ++-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/channels.c b/channels.c
index f1d7bcf345b19..80014ff341fad 100644
--- a/channels.c
+++ b/channels.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: channels.c,v 1.451 2025/09/25 06:33:19 djm Exp $ */
+/* $OpenBSD: channels.c,v 1.452 2025/10/07 08:02:32 djm Exp $ */
/*
* Author: Tatu Ylonen
* Copyright (c) 1995 Tatu Ylonen , Espoo, Finland
@@ -362,7 +362,7 @@ channel_classify(struct ssh *ssh, Channel *c)
{
struct ssh_channels *sc = ssh->chanctxt;
const char *type = c->xctype == NULL ? c->ctype : c->xctype;
- const char *classifier = c->isatty ?
+ const char *classifier = (c->isatty || c->remote_has_tty) ?
sc->bulk_classifier_tty : sc->bulk_classifier_notty;
c->bulk = type != NULL && match_pattern_list(type, classifier, 0) == 1;
@@ -566,7 +566,7 @@ channel_new(struct ssh *ssh, char *ctype, int type, int
rfd, int wfd, int efd,
void
channel_set_tty(struct ssh *ssh, Channel *c)
{
- c->isatty = 1;
+ c->remote_has_tty = 1;
[continued in next message]
--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)
|
